Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provider nil fields #4758

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix: provider nil fields #4758

merged 2 commits into from
Mar 7, 2024

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Mar 7, 2024

Description

Fixes #4759

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kartik-579 kartik-579 merged commit 36398db into main Mar 7, 2024
9 of 10 checks passed
@kartik-579 kartik-579 deleted the nil-provider-fixes branch March 7, 2024 10:21
raunit-verma pushed a commit to raunit-verma/devtron that referenced this pull request Mar 11, 2024
* fixed provider nil fields

* updated wire_gen.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Nil fields set in provider and redundant impl fields fix
2 participants